Don't automatically autocomplete () after ? and certain special functions
#369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jennybc
added a commit
that referenced
this pull request
Jan 29, 2025
jennybc
added a commit
that referenced
this pull request
Feb 10, 2025
* Analyze completion site re: trailing parens * Start dismantling measures that just aided development * More parallel with the other branch * Get inspired by the less nested approach in PR #369 * Must have been leftover from an experiment * Add tests * Be consistent * Try to get a bit more info on the Windows test failure * Flatten this out too * Not my problem to solve: Revert "Try to get a bit more info on the Windows test failure" This reverts commit dea921d. This is unrelated to this PR and is being tracked in #678. * Remove rest of temporary logging * Extract out `node_find_containing_call()` * Rework on top of `parameter_hints()` idea * Add `ParameterHints` enum And fix a bug with imports environment functions not respecting `parameter_hints` * Move tests to `parameter_hints.rs` It seems obvious to me that we are testing a feature that "officially" lives here now * Tweak examples probed in tests * Add comment * Use original name of function --------- Co-authored-by: Davis Vaughan <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#2338
Addresses part of posit-dev/positron#1818